Repository navigation
Add editable drilled plates and brackets - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a mechanical part builder for rectangular mounting plates and sharp right-angle brackets. Users enter stock dimensions and independent centered through-hole grids for both bracket flanges, preview the layouts, then create or atomically revise one editable native solid. Invalid configurations are rejected before kernel work; failed edits retain the previous part and parameters. Saved native documents retain the builder settings, with one undo unit per accepted edit.
The home and Model ribbon expose Create/Edit mechanical part, with keyboard controls, inline errors, light/dark styling, a compact editor, and labels in all four shipped locales. Documentation describes the supported geometry, limits and inherited infrastructure. The profile contribution wording is a separate, accurate follow-up.
Validation: 34 focused tests across four files passed, including real OpenCascade volume and containment checks, closure/validity, pre-kernel rejection, edit failure/undo/redo, serialization, STEP roundtrip, STL structure and a 32-hole part. TypeScript, scoped Biome, and app plus bundled-plugin builds passed; existing size warnings remain. Native browser checks covered bracket creation, nondefault edit/undo/redo, fresh-page Recent-project reopening with all settings, 390px validation/cancel, and light-theme plate creation.
The in-app browser reported Downloading for native backup and STEP export but supplied no completed download artifacts; browser file import/download completion is not claimed. Kernel exchange and serialization are tested separately. Brackets are ideal sharp geometry, without bend allowance or structural/manufacturing certification. This adds parameter editing, not separate operation rows in the inherited feature timeline. Existing licenses and source credits are preserved.