Include fingerprint in print and JSON format output#149
Include fingerprint in print and JSON format output#149sb8244 wants to merge 2 commits intonccgroup:masterfrom
Conversation
This fingerprint allows selectively targeting violations using a skip file.
|
I find this use-case super interesting and totally makes sense, thank you for contributing this! I'm honestly surprised that this wasn't a part of Sobelow before, especially since it already has the functionality to parse out skipped finding fingerprints from the So my question for you is: what does your proposed flow look like? You mention a single central file instead with a written explanation - would it make sense to fold into this PR, a change to the way the |
|
Apologies for the delay. Right now (for better or worse), there weren't any code changes required to get the skips working. This is because each line is treated as a fingerprint and blindly compared when skipping. Putting invalid fingerprints there is totally fine—they just won't match anything. The thing that I like about this is that there's no breaking changes required—or changes at all—to how the fingerprint parsing and skipping is done. However, I could see why some people wouldn't like this because it isn't an intended use case of the code. Personally, I like the way it came out, although |
This fingerprint allows selectively targeting violations using a skip file.
Use Case: I want to selectively skip violations with a written explanation as to why it's a false positive. I want to keep this in a single central file instead of using the comment-based skip approach.