Skip to content

Make DfsDiagTestDCs independent of English output #126

Description

@ndemou

Problem

HealthTest-DfsDiagTestDCs removes a short list of expected English lines from DFSDIAG /TestDCs output. Anything left is treated as failure.

File: health-tests/HealthTest-DfsDiagTestDCs.ps1, lines 13-19.

Normal output is translated on non-English Windows, so successful diagnostics can be reported as failed. The command exit code is also ignored.

Simple example

DFSDIAG succeeds on Greek Windows. Its translated lines do not start with the English words in the filter, so they remain in $out and the test reports FAILURE.

Expected behavior

Use the command exit code and language-independent result data. Treat unfamiliar output as unknown rather than automatically good or bad.

Acceptance criteria

  • Successful localized output does not produce FAILURE.
  • A nonzero command result cannot produce PASS.
  • Unrecognized output is reported clearly.
  • Unit tests cover English, non-English, and command-failure output.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions