fix: move react-select from peer-dep to dev-dep#146
Open
benjitrosch wants to merge 1 commit intondom91:mainfrom
Open
fix: move react-select from peer-dep to dev-dep#146benjitrosch wants to merge 1 commit intondom91:mainfrom
benjitrosch wants to merge 1 commit intondom91:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The documentation indicates that
react-selectis optional if end users are only interested in theuseTimezoneSelecthook. However, by makingreact-selecta peer dependency, it will be installed anyways.This PR moves
react-selectfrom peer dependencies to dev dependencies. By doing this, we can be sure the package will always be available on install for dev work, but will not install itself without the end user wanting it.Linked Issues
fix: #145