-
Notifications
You must be signed in to change notification settings - Fork 2
depend on nebari-app chart #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pmeier
wants to merge
11
commits into
main
Choose a base branch
from
nebari-app-chart
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
83f1a81
depend on nebari-app chart
pmeier 47c74a8
cleanup
pmeier ef9b445
Merge branch 'main' into nebari-app-chart
pmeier 9bab334
cleanup
pmeier 0e9ab6c
cleanup
pmeier 25741b6
Merge branch 'main' into nebari-app-chart
pmeier 687f89c
address comments
pmeier 7b861b5
tmp depend on dev version of chart
pmeier 1874e30
newlinw
pmeier e7d647d
depend on next dev version
pmeier edfda34
final dev chart
pmeier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| {{- define "nebari-chat.nebariapp" -}} | ||
| {{- $top := .top -}} | ||
| {{- $component := .component -}} | ||
| {{- $spec := .spec -}} | ||
| {{- include "nebari-app.nebariApp" (dict | ||
| "metadata" (dict | ||
| "name" (include "ravnar.component-name" (dict "top" $top "component" $component)) | ||
| "namespace" $top.Release.Namespace | ||
| "labels" (include "ravnar.labels" (dict "top" $top "component" $component) | fromYaml) | ||
| ) | ||
| "spec" $spec | ||
| "tplCtx" $top | ||
| ) -}} | ||
| {{- end -}} | ||
| apiVersion: v1 | ||
| kind: Namespace | ||
| metadata: | ||
| name: {{ .Release.Namespace }} | ||
| labels: | ||
| nebari.dev/managed: "true" | ||
| {{- include "ravnar.labels" (dict "top" . "component" "nebariapp") | nindent 4 }} | ||
| --- | ||
| {{ include "nebari-chat.nebariapp" (dict | ||
| "top" . | ||
| "component" "backend" | ||
| "spec" .Values.backend.nebariapp | ||
| ) }} | ||
| --- | ||
| {{ if .Values.frontend.enabled }} | ||
| {{- include "nebari-chat.nebariapp" (dict | ||
| "top" . | ||
| "component" "frontend" | ||
| "spec" .Values.frontend.nebariapp | ||
| ) }} | ||
| {{- end }} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This meant that the service was not user configurable before and while dynamically computed as part of the template was fixed by the chart. This can be seen in the custom services diff in this comment. With this PR the dynamic default stays, but user override is now possible.