Skip to content

feat: add githubHref and logo theme options - #31

Merged
jbouder merged 1 commit into
mainfrom
feat/github-href-and-logo-options
Aug 26, 2026
Merged

feat: add githubHref and logo theme options#31
jbouder merged 1 commit into
mainfrom
feat/github-href-and-logo-options

Conversation

@jbouder

@jbouder jbouder commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

Adds two backwards-compatible options to nebari() so consuming docs sites can customize the header without copying component overrides:

  • githubHref — points the header GitHub icon at a specific repository instead of the hard-coded https://github.com/nebari-dev org link. This lets each pack link the icon to its own repo with one line of config (replacing the SocialIcons.astro workaround nebari-frames currently carries).
  • logo — replaces the bundled Nebari mark in the header with the site's own images: { light, dark, alt }. Values are used as the <img src> verbatim (files in public/, or absolute URLs; root-absolute paths get the site base prefixed at build time by the existing withBasePrefix pass). Omitted variants cross-fall back so a single-image logo only needs light; alt defaults to "Nebari"; omitting the option entirely keeps the bundled mark.

Both options flow through the existing virtual:nebari/config module; virtual.d.ts and the README are updated accordingly.

Version bumped to 0.3.0 (EffVer meso — new features, no breaking changes), so this is release-ready on merge.

Motivation

The Nebari packs portal wants every pack's docs header to link the logo to https://packs.nebari.dev and the GitHub icon to the pack's own repository. Today logoHref covers the first, but the GitHub icon is hard-coded to the org, forcing per-pack SocialIcons component copies. These options make both one-line config changes in each pack.

Testing

  • New packages/starlight/test/options.test.ts covers: default org link, githubHref override, consumer social entries preserved, logo defaulting to null, variant cross-fallback, explicit variants + alt, and logoHref pass-through.
  • Full suite (bun test, including the docs build tests): 25 pass / 0 fail.
  • bun run check (biome): clean.

Close #30

🤖 Generated with Claude Code

Two new options on nebari():

- githubHref: points the header GitHub icon at a specific repository
  instead of the hard-coded nebari-dev org link, so each pack's docs can
  link to its own repo without copying a SocialIcons override.
- logo: replaces the bundled Nebari mark in the header with the site's
  own light/dark images and alt text. Omitted variants cross-fall back
  so a single-image logo only needs one entry; no option keeps the
  bundled mark.

Version bumped to 0.3.0 (EffVer meso: new backwards-compatible options).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@jbouder
jbouder merged commit ee80161 into main Aug 26, 2026
2 checks passed
@jbouder
jbouder deleted the feat/github-href-and-logo-options branch August 26, 2026 11:50
This was referenced Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a "See All Packs" link to the docs site header

1 participant