Support CUDA 13 scan comparators - #310
Open
jeongseok-meta wants to merge 1 commit into
Open
Conversation
jeongseok-meta
marked this pull request as ready for review
August 20, 2026 18:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cub::Equalityscan comparator withthrust::equal_to<int64_t>Why
CUDA 13's CUB no longer provides
cub::Equality, which prevents the extension from compiling. NerfAcc's scan keys areint64_tin both the forward and reverse-iterator paths, so the typed Thrust comparator preserves the existing behavior.Using the Thrust functor also keeps the source compatible with older supported CUDA toolkits without a CUDA-version conditional.
Closes #306.
Validation
cub::Equalityerrors.sm_120).pytest -q tests/test_scan.py: 4 passed.pytest -q: 23 passed.git diff --check.