Fix bug: onDragLeave doesn't reset over-class

[denkan]

Fixed bug causing nv-file-over (over-class) not resetting when leaving element.
Issue e.g. #514 and #231.

Fixed by removing the check (and cancel) if the event.currentTarget is same as the nv-file-over element. Seems like we don't need it because the onDragOver event will put it right back anyway.

Tested in Chrome, Firefox, Safari.
Could need testing in IE?

[nervgh]

Thanks, but what about these issues?

#332
#237
#450
#312
#331
#286

[denkan]

Yea, sorry... should've known it wasn't that simple :)
I'll be happy to take a look when I have little more time.

Great module btw!

[denkan]

Alright, I couldn't really put it out of my mind.
I got it working fine on my test browsers by wrapping the onDragLeave logic into a timer @ 50ms. By doing that, the onDragOver has time to reset the timer if it's still hovering/dragging valid element.

A bit hacky but seems to work...

[theoomoregbee]

I just bower installed ur directive same issue , the over-class still persist after on drag out

[theoomoregbee]

This is what i finally used in manipulating it from my controller

var element=angular.element(document.getElementById("basic"));
            element.on('dragleave', function () {
                        element.removeClass("nv-file-over");
                        element.removeClass("test"); //used for my over-class
                        console.log('dragleave');
                    });
`

[denkan]

@Theo4u: you installed from bower, meaning you didn't try my fix in this pull request?

@nervgh: have you had the time to look into my last suggestion, using timeout? Any thoughts?

[theoomoregbee]

the request should have been merged already, am working on a project here , so i dont really have time to check, it should be updated for the next version , so bower install should give the latest updates. Thanks

[nervgh]

@nervgh: have you had the time to look into my last suggestion, using timeout? Any thoughts?

It looks like your code will cause the flicker effect again.

[denkan]

@nervgh: Really? That's odd, it's working fine on my side.

Just to be sure; I'm aware that my initial PR commit caused the flicker effect again, but you did see my later commit (226e6e6) where I use the timeout to fix that? Still causing the flickering on your end?

[Stalinko]

This fix is the best one and fully solves the issue. Unlike #720.