feat: update macOS build configuration for portability#1237
Open
chenyukang wants to merge 1 commit intonervosnetwork:developfrom
Open
feat: update macOS build configuration for portability#1237chenyukang wants to merge 1 commit intonervosnetwork:developfrom
chenyukang wants to merge 1 commit intonervosnetwork:developfrom
Conversation
eval-exec
reviewed
Apr 4, 2026
Comment on lines
+129
to
+131
| export OPENSSL_PREFIX="$(brew --prefix openssl@1.1)" | ||
| export OPENSSL_LIB_DIR="${OPENSSL_PREFIX}/lib" | ||
| export OPENSSL_INCLUDE_DIR="${OPENSSL_PREFIX}/include" |
There was a problem hiding this comment.
Since tentacle-secio provides the openssl-vendor feature, we could statically link OpenSSL into the Fiber binary by enabling this feature.
https://github.com/nervosnetwork/tentacle/blob/87ef6d9bd659012bb1394f5f3e8ccd4f8e615197/secio/Cargo.toml#L53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add release target for
aarch64-apple-darwin.