Skip to content

Fix cargo cache paths and trim unused Rust std targets in PR check #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Finesssee merged 3 commits into from
Jul 29, 2026
Merged

Fix cargo cache paths and trim unused Rust std targets in PR check #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb234a4
Fix cargo cache paths and trim unused Rust std targets in PR check
Finesssee Jul 29, 2026
bc55e98
Consolidate PR check cargo steps to workspace-level invocations
Finesssee Jul 29, 2026
2bfb435
Address review: default rust-cache workspace, comment target removal,…
Finesssee Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/CI.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,8 @@ Exact commands run, in order:

```powershell
cargo fmt --all --check
cargo clippy --manifest-path rust/Cargo.toml --all-targets -- -D warnings
cargo clippy --manifest-path apps/desktop-tauri/src-tauri/Cargo.toml --all-targets -- -D warnings
cargo test --manifest-path rust/Cargo.toml
cargo test --manifest-path apps/desktop-tauri/src-tauri/Cargo.toml
cargo clippy --workspace --all-targets -- -D warnings
cargo test --workspace
pnpm --dir apps/desktop-tauri test
pnpm --dir apps/desktop-tauri run build
```
Expand Down
24 changes: 10 additions & 14 deletions .github/workflows/pr-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@ jobs:
steps:
- uses: actions/checkout@v4

# The runner image preinstalls these std targets; dropping them before the
# stable sync avoids re-downloading rust-std for targets CI never builds.
- name: Remove unused preinstalled Rust targets
run: rustup target remove x86_64-pc-windows-gnu i686-pc-windows-msvc
continue-on-error: true

- name: Install Rust
uses: dtolnay/rust-toolchain@stable
with:
Expand All @@ -40,10 +46,6 @@ jobs:

- name: Cache cargo
uses: Swatinem/rust-cache@v2
with:
workspaces: |
rust
apps/desktop-tauri/src-tauri

- name: Setup pnpm
uses: pnpm/action-setup@v4
Expand All @@ -63,17 +65,11 @@ jobs:
- name: Rust format check
run: cargo fmt --all --check

- name: Shared Rust clippy
run: cargo clippy --manifest-path rust/Cargo.toml --all-targets -- -D warnings

- name: Tauri Rust clippy
run: cargo clippy --manifest-path apps/desktop-tauri/src-tauri/Cargo.toml --all-targets -- -D warnings

- name: Shared Rust tests
run: cargo test --manifest-path rust/Cargo.toml
- name: Rust clippy (workspace)
run: cargo clippy --workspace --all-targets -- -D warnings

- name: Tauri Rust tests
run: cargo test --manifest-path apps/desktop-tauri/src-tauri/Cargo.toml
- name: Rust tests (workspace)
run: cargo test --workspace

- name: Frontend tests
run: pnpm --dir apps/desktop-tauri test
Expand Down
Loading