Repository navigation
docs(file-storage): document custom upload content-type detection - #3609
Merged
Merged
Conversation
Cover the detectContentType and contentTypeSampleBytes options that uploadToDisk() gained in @nestjs/storage 0.0.2, with a CSV example, and separate the option from the exported detectContentType() helper. Closes #3599
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
Closes #3599.
The file storage chapter doesn't mention the
detectContentTypeandcontentTypeSampleBytesoptions thatuploadToDisk()gained in nestjs/storage#13 (released in@nestjs/storage0.0.2). A reader who wants CSV uploads would addtext/csvtocontentTypesand find every upload refused with a415.What is the new behavior?
contentTypeSampleBytes;contentTypes, with a415before any write;.csvextension being used for storage and the key;uploadToDisk()row. ThedetectContentType(bytes)row now separates the exported helper from the option.Every behavior described was checked against
@nestjs/storage0.0.2: directly againstuploadToDisk(), and through a real Nest + multer app for the HTTP statuses (CSV201, unknown header415, throwing or non-string detector500, thrownHttpExceptionkeeps its status).Does this PR introduce a breaking change?
Other information
npm run buildpasses, and the dangling-links list has no new entries. The example decodes withTextDecoderrather thanreplace(/^/, ''), because the markdown pipeline turns thatescape into a literal, invisible BOM.