fix(plugin): handle decorators with property access expressions in getIdentifierFromName - #4042
Open
jorenl wants to merge 1 commit into
Open
Conversation
…ions in getIdentifierFromName
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When the plugin inspects decorators that use a property access expression, such as with a namespace import in the below example, the
getIdentifierFromName()utility function throws and the decorator is not handled.Issue Number: N/A
What is the new behavior?
The decorator name identifier is returned,
IsInin the above example, and the decorator is handled.Does this PR introduce a breaking change?
Other information
Since
getNameFromExpressionright below has explicit support for property access expressions, I believe this is was a simple typo. (checkingexpressioninstead ofidentifierreturn bygetNameFromExpression, which is then returned).I ran into this issue while developing a different NestJS CLI plugin, which I want to run before the
@nestjs/swaggerone, which is generating class-validator and class-transformer decorators based on typescript types. Without using namespace imports, typescript strips the necessary import declarations when emitting, which I believe is why this plugin uses the same technique inabstract.visitor.ts.This is my first PR in this repo, so if I'm not following correct patterns, let me know and I'll happily adjust.