-
Notifications
You must be signed in to change notification settings - Fork 32
ci: surface code coverage on pull requests #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c1277ba
ci: surface code coverage on pull requests
leoparente 2dd0c05
ci(coverage): post a per-PR coverage comment via lcov-reporter-action
leoparente 002f7f2
ci(coverage): grant issues:write for the comment-posting action
leoparente f063c98
ci(coverage): exclude system + STL headers from lcov report
leoparente 0e0e12f
ci(coverage): tolerate unused exclude patterns + drop non-Linux ones
leoparente 96b6608
ci(coverage): render PR comment from lcov --list to avoid truncation
leoparente 70a573f
ci(coverage): switch to zgosalvez/github-actions-report-lcov
leoparente File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| coverage: | ||
| # Both gates are informational — they show up in PR comments and Codecov | ||
| # status checks but never block merge. Flip `informational: false` later | ||
| # when we want to enforce a floor. | ||
| status: | ||
| project: | ||
| default: | ||
| target: auto | ||
| threshold: 1% | ||
| informational: true | ||
| patch: | ||
| default: | ||
| target: auto | ||
| informational: true | ||
|
|
||
| comment: | ||
| layout: "diff, flags, files" | ||
| behavior: default | ||
| require_changes: false | ||
|
|
||
| ignore: | ||
| # Vendored third-party code we don't own | ||
| - "3rd/**" | ||
| # Build artifacts and generated headers | ||
| - "build/**" | ||
| - "**/*.pb.h" | ||
| - "**/*.pb.cc" | ||
| # Test sources themselves don't need to be coverage targets | ||
| - "**/tests/**" | ||
| - "**/test_*.cpp" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step unconditionally runs on every
pull_request, but for forked PRs (and Dependabot PRs) GitHub downgradesGITHUB_TOKENto read-only, sogithub-actions-report-lcovcannot update the PR comment and will fail with a 403. That turns the new coverage workflow into a red check for external contributions even when tests and coverage generation succeed; gate this step to non-fork PRs (or make it non-blocking) to avoid breaking contributor PRs.Useful? React with 👍 / 👎.