Use TypeScript 6 for Learn tooling - #3030
Merged
Merged
Conversation
✅ Deploy Preview for netdata-docusaurus ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request updates the ChangesTypeScript dependency upgrade
Estimated code review effort: 1 (Trivial) | ~2 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compatibility rationale
TypeScript 6 is the stable transition release and remains API-compatible with TypeScript 5.9. TypeScript 7.0 does not expose a stable programmatic API, and Microsoft recommends that MDX projects remain on TypeScript 6 until that support is available.
Learn currently has no TypeScript source files or tsconfig. This update aligns the direct tooling dependency without changing the site runtime or rendered content.
Validation
Summary by cubic
Upgrade root
typescriptfrom 5.9.3 to 6.0.3 to align Learn’s tooling with the stable transition release. Keeps the compiler API andtsserverused by MDX tooling while avoiding TypeScript 7’s unstable programmatic API; no changes to site runtime or rendered output.Review notes
package.jsonandyarn.lockchanged; lockfile remains on npmjs provenance.Written for commit 0d0335a. Summary will update on new commits.
Summary by CodeRabbit