Repository navigation
Conversation
✅ Deploy Preview for netdata-docusaurus ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 24 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
1 issue found across 6 files
Confidence score: 3/5
deploymentIntegrations.test.jsstill expects@netlify/blobs11.0.1, butvendor-checksums.jsonnow specifies 11.1.4, so the test will fail. Update the expected dependency contract.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="scripts/verify-indexnow-vendor.js">
<violation number="1" location="scripts/verify-indexnow-vendor.js:23">
P2: `src/seo/deploymentIntegrations.test.js` still asserts the old dependency contract (`dependencies: {'@netlify/blobs': '11.0.1', saxes: '6.0.0'}`) against `vendor-checksums.json`, which this PR updates to 11.1.4. Because `toMatchObject` requires the value to match exactly, the repo's own vitest suite (`yarn test` / `test:run`) fails after merge. Update line 106 to `'11.1.4'`, and verify the full `test:run` rather than only the 64 owner plugin tests.</violation>
</file>
Architecture diagram
sequenceDiagram
participant CI as CI / Publication Pipeline
participant Install as Yarn Install (frozen)
participant Verify as verify-indexnow-vendor.js
participant Plugin as Netlify IndexNow Plugin
participant NetlifySDK as @netlify/blobs 11.1.4
participant NetlifyEdge as Netlify Blob Store
Note over CI,NetlifyEdge: Dependency update to @netlify/blobs 11.1.4 (schema-2 vendored contract)
CI->>Install: Install dependencies (--frozen-lockfile)
Install-->>CI: Installed @netlify/blobs 11.1.4
CI->>Verify: Run six-file vendor verifier
Verify->>Verify: Load vendor-checksums.json
Verify->>Verify: Compare SHA-256 of 6 files (incl. package.json)
alt Checksums match contract
Verify-->>CI: Vendor contract verified
else Checksum mismatch
Verify-->>CI: Fail build (throw error)
end
Note over Plugin,NetlifyEdge: Runtime (unchanged logic, new SDK version)
Plugin->>NetlifySDK: Use blob operations (strong-consistency get/put)
NetlifySDK->>NetlifyEdge: REST calls for blob storage
NetlifyEdge-->>NetlifySDK: Immutable receipt (schema-2)
NetlifySDK-->>Plugin: Operation result
Note over CI,NetlifyEdge: Local validation used mocked fetch only (no live persistence)
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
ktsaou
marked this pull request as draft
October 9, 2026 09:36
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Learn's exact Netlify Blob SDK to 11.1.4 through the published Website owner in https://github.com/netdata/website/pull/1409. Import the same six checksum-covered files, manifest and verifier, and record owner commit
5670562137379be4cfeac2538297d13ad503138b. Only the covered package declaration and its checksum change; core logic, schemas and submission behavior remain unchanged.Validation: forced frozen Yarn install, six-file verifier, all 64 existing plugin tests and byte comparison against the published owner passed. The installed SDK's strong-consistency and immutable receipt operations passed with mocked fetch only; no URLs were submitted and no live Netlify persistence is claimed. Renderer inputs are unchanged, so local qualification does not repeat the site build; normal publication CI remains required.
Merge the owner before this handoff. This is an isolated dependency unit; other pending runtime, gate and security changes remain separate.
Summary by cubic
Updates
@netlify/blobsto 11.1.4 so Learn's vendored IndexNow plugin matches the refreshed shared SDK contract fromnetdata/website(owner commit5670562137379be4cfeac2538297d13ad503138b). Only the covered package declaration and its checksum change; core logic, schemas, and submission behavior remain identical.Validation
netdata/websitemust merge before this one.Written for commit 3bdc927. Summary will update on new commits.