Skip to content

Import the refreshed shared IndexNow Blob SDK contract - #3132

Closed
ktsaou wants to merge 1 commit into
masterfrom
deps/refresh-indexnow-blob-sdk
Closed

ktsaou wants to merge 1 commit into
masterfrom
deps/refresh-indexnow-blob-sdk

Conversation

@ktsaou

@ktsaou ktsaou commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Update Learn's exact Netlify Blob SDK to 11.1.4 through the published Website owner in https://github.com/netdata/website/pull/1409. Import the same six checksum-covered files, manifest and verifier, and record owner commit 5670562137379be4cfeac2538297d13ad503138b. Only the covered package declaration and its checksum change; core logic, schemas and submission behavior remain unchanged.

Validation: forced frozen Yarn install, six-file verifier, all 64 existing plugin tests and byte comparison against the published owner passed. The installed SDK's strong-consistency and immutable receipt operations passed with mocked fetch only; no URLs were submitted and no live Netlify persistence is claimed. Renderer inputs are unchanged, so local qualification does not repeat the site build; normal publication CI remains required.

Merge the owner before this handoff. This is an isolated dependency unit; other pending runtime, gate and security changes remain separate.


Summary by cubic

Updates @netlify/blobs to 11.1.4 so Learn's vendored IndexNow plugin matches the refreshed shared SDK contract from netdata/website (owner commit 5670562137379be4cfeac2538297d13ad503138b). Only the covered package declaration and its checksum change; core logic, schemas, and submission behavior remain identical.

Validation

  • Forced frozen Yarn install, the six-file verifier, all 64 plugin tests, and byte comparison against the published owner passed.
  • The SDK's strong-consistency and immutable receipt operations were verified with mocked fetch only; no URLs were submitted and no live Netlify persistence is claimed.
  • Renderer inputs are unchanged, so local checks don't rerun the site build; normal publication CI is still required.
  • The owner PR in netdata/website must merge before this one.

Written for commit 3bdc927. Summary will update on new commits.

View guided diff Turn on auto-fix

@ktsaou
ktsaou requested a review from a team as a code owner October 9, 2026 00:35
@ktsaou
ktsaou requested review from mtblz and witalisoft October 9, 2026 00:35
@netlify

netlify Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for netdata-docusaurus ready!

Name Link
🔨 Latest commit 3bdc927
🔍 Latest deploy log https://app.netlify.com/projects/netdata-docusaurus/deploys/6ac836b643f7880008bbffbb
😎 Deploy Preview https://deploy-preview-3132--netdata-docusaurus.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 24 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 035a6f54-af5d-4296-ab4f-fd5361a64293
📥 Commits

Reviewing files that changed from the base of the PR and between 3e846ee and 3bdc927.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (5)
  • package.json
  • plugins/netlify-plugin-indexnow/README.md
  • plugins/netlify-plugin-indexnow/package.json
  • plugins/netlify-plugin-indexnow/vendor-checksums.json
  • scripts/verify-indexnow-vendor.js
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 6 files

Confidence score: 3/5

  • deploymentIntegrations.test.js still expects @netlify/blobs 11.0.1, but vendor-checksums.json now specifies 11.1.4, so the test will fail. Update the expected dependency contract.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="scripts/verify-indexnow-vendor.js">

<violation number="1" location="scripts/verify-indexnow-vendor.js:23">
P2: `src/seo/deploymentIntegrations.test.js` still asserts the old dependency contract (`dependencies: {'@netlify/blobs': '11.0.1', saxes: '6.0.0'}`) against `vendor-checksums.json`, which this PR updates to 11.1.4. Because `toMatchObject` requires the value to match exactly, the repo's own vitest suite (`yarn test` / `test:run`) fails after merge. Update line 106 to `'11.1.4'`, and verify the full `test:run` rather than only the 64 owner plugin tests.</violation>
</file>
Architecture diagram
sequenceDiagram
    participant CI as CI / Publication Pipeline
    participant Install as Yarn Install (frozen)
    participant Verify as verify-indexnow-vendor.js
    participant Plugin as Netlify IndexNow Plugin
    participant NetlifySDK as @netlify/blobs 11.1.4
    participant NetlifyEdge as Netlify Blob Store

    Note over CI,NetlifyEdge: Dependency update to @netlify/blobs 11.1.4 (schema-2 vendored contract)

    CI->>Install: Install dependencies (--frozen-lockfile)
    Install-->>CI: Installed @netlify/blobs 11.1.4

    CI->>Verify: Run six-file vendor verifier
    Verify->>Verify: Load vendor-checksums.json
    Verify->>Verify: Compare SHA-256 of 6 files (incl. package.json)
    alt Checksums match contract
        Verify-->>CI: Vendor contract verified
    else Checksum mismatch
        Verify-->>CI: Fail build (throw error)
    end

    Note over Plugin,NetlifyEdge: Runtime (unchanged logic, new SDK version)

    Plugin->>NetlifySDK: Use blob operations (strong-consistency get/put)
    NetlifySDK->>NetlifyEdge: REST calls for blob storage
    NetlifyEdge-->>NetlifySDK: Immutable receipt (schema-2)
    NetlifySDK-->>Plugin: Operation result

    Note over CI,NetlifyEdge: Local validation used mocked fetch only (no live persistence)
Loading

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread scripts/verify-indexnow-vendor.js
@ktsaou
ktsaou marked this pull request as draft October 9, 2026 09:36
@ktsaou

ktsaou commented Oct 9, 2026

Copy link
Copy Markdown
Member Author

Superseded by #3136 (#3136), which combines all supported Learn package, runtime, tooling and copied-browser-asset updates with a fresh inventory and combined validation. This proposal's history and branch are retained; review the combined draft instead.

@ktsaou ktsaou closed this Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant