Skip to content

fix: await function template downloads in functions-create #8465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jherr wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

fix: await function template downloads in functions-create #8465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/commands/functions/functions-create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { mkdir, readdir, unlink } from 'fs/promises'
import { createRequire } from 'module'
import path, { dirname, join, relative } from 'path'
import process from 'process'
import { pipeline } from 'stream/promises'
import { fileURLToPath, pathToFileURL } from 'url'

import { OptionValues } from 'commander'
Expand Down Expand Up @@ -409,10 +410,13 @@ const downloadFromURL = async function (command, options, argumentName, function
folderContents.map(async ({ download_url: downloadUrl, name }) => {
try {
const res = await fetch(downloadUrl)
if (!res.ok || !res.body) {
throw new Error(`HTTP ${res.status.toString()}: ${res.statusText}`)
}
const fileName = path.basename(name)
const finalName = path.basename(fileName, '.js') === functionName ? `${nameToUse}.js` : fileName
const dest = fs.createWriteStream(path.join(fnFolder, finalName))
res.body?.pipe(dest)
await pipeline(res.body, dest)
} catch (error_) {
throw new Error(`Error while retrieving ${downloadUrl} ${error_}`)
}
Expand Down
Loading