[nettrash]

closes #243

[Copilot]

🟢 Approval recommended

The change correctly reorders identity-drop statements to satisfy PostgreSQL ALTER constraints and is backed by focused unit tests and fixtures covering the reported and related failure modes.

Pull request overview

Fixes Issue #243 by making TableColumn::get_alter_script emit DROP IDENTITY before any per-column ALTERs that relax identity constraints (type/default/nullability), preventing PostgreSQL from rejecting the migration when identity is removed alongside other changes.

Changes:

• Emit ALTER ... DROP IDENTITY IF EXISTS at the start of a column’s ALTER list; keep identity add/update logic after type/default/nullability handling.
• Add targeted unit tests to assert correct intra-column statement ordering for identity drop/add scenarios.
• Add schema fixtures + README/CHANGELOG documentation covering the regression and its verification.

File summaries

File	Description
app/src/dump/table_column.rs	Reorders identity-drop emission ahead of type/default/nullability ALTERs to satisfy PostgreSQL constraints.
app/src/dump/tests/table_column.rs	Adds unit tests asserting identity drop precedes DROP NOT NULL, SET DEFAULT, and type changes; and identity add ordering remains correct.
data/test/schema_a.sql	Adds FROM-side fixture table with identity columns that will relax identity guarantees in TO.
data/test/schema_b.sql	Adds TO-side fixture table where identity is removed and one constraint is relaxed per column.
data/test/README.md	Documents the new Issue #243 fixture and why ordering must be identity-first on drop.
CHANGELOG	Notes Issue #243 fix and explains the underlying ordering constraint.

Review details

• Files reviewed: 6/6 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.