Repository navigation
Give a point-level correction its own coordinate verdict - #36
Merged
Merged
Conversation
A reviewer who fixes an analysis's points (a dropped minus sign, a misread value, a point added to, removed from or moved out of it) changes its content key, but no verdict said "the same analysis, points corrected", so it could only be written as a split with one replacement. AuditVerdict gains edit: its key changes because its content did, and everything stored against it is copied to its one replacement, as for a split. check_revision refuses an edit that names no replacement, more than one, or itself (unchanged content is an accept). Point order is not part of the key, so reordering points is not an edit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reviewer who corrects an analysis's points changes its content key. Examples are a dropped minus sign, a misread value, or a point added to, removed from or moved out of the analysis. No
AuditVerdictsaid "the same analysis, points corrected", so such a correction could only be written as a split with one replacement. This is the third of the PRs for neurostore's review app, after #34 and #35.What changes
AuditVerdictgainsedit. Its key changes because its content did, and everything stored against it is copied to its one replacement, as for a split. Point order is not part of the key, so reordering points is not an edit.AnalysisVerdictandreplaced_bydescriptions, and the README's revision paragraph, includeedit.check_revisionrefuses an edit that names no replacement, more than one, or itself. An edit naming itself has unchanged content, which is an accept. LinkML rules aren't emitted into the generated JSON Schema or the pydantic models, so the one-replacement rule lives in this check and in the description.Tests
check_revisionaccepts a valid edit, and refuses zero keys,None, two keys, and the edit's own key.generate_models.py --checkpasses.For consumers: an ingester treats
editlike a one-replacement split. It copies claims to the replacement, leaves the old key out of projections, and maps the old key to the new one. Neurostore's ingester will follow in its own PR.🤖 Generated with Claude Code