Repository navigation
Ship the LinkML source with the package - #37
Merged
Merged
Conversation
The LinkML YAML sat at the repo root, outside the package, so a consumer that depends on study_schema could reach it only through a git export. It now lives under src/study_schema/linkml/, shipped as package data, with study_schema.linkml.EXTRACTION, STORAGE and PAPER_PARSE as the paths of the three schemas. The extraction deviations and the extraction-to-storage map, which pondie checks the projection against, moved with them; storage-parameter-priorities.yaml is triage data and stays at the root. The generator reads its schemas through the same module, and a test builds a wheel and checks every YAML file is in it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LinkML YAML sat at the repo root, outside the package, so a consumer that depends on study_schema could reach it only through a git export. Neurostore's tests did exactly that, with a gitignored
git archiveof the pinned commit. This is the fourth of the PRs for neurostore's review app.What changes
extraction-evidence.yamlmove tosrc/study_schema/linkml/, shipped as package data. Git shows them as renames.extraction-deviations.yamlandextraction-to-storage.map.yamlmove with them, because pondie checks the projection against them.storage-parameter-priorities.yamlis triage data and stays at the root; the README says it isn't packaged.study_schema.linkml.EXTRACTION,STORAGEandPAPER_PARSEarepathlib.Paths of the three schemas. Relative imports resolve inside the packaged tree.tools/generate_models.pyreads the schemas through that module. Generated output is unchanged (--check).Needs a change in pondie:
python3 -m pondie.schema.generatewrites these files to the repo root. It must write intosrc/study_schema/linkml/instead, or regenerating will leave stale copies at the root.Tests
tests/test_linkml.pychecks that every constant points at a packaged schema, and that every relative import resolves inside the packaged tree.setuptools.build_metaand checks every YAML file is in it, the two moved contract files by name. CI's pip install provides setuptools, so this test runs there.pytest testspasses (125 passed, 2 skipped where setuptools or pyarrow is missing locally), andgenerate_models.py --checkpasses.🤖 Generated with Claude Code