New Extension: Addressbar Updater#1656
Open
srsutherland wants to merge 17 commits intonew-xkit:masterfrom
Open
New Extension: Addressbar Updater#1656srsutherland wants to merge 17 commits intonew-xkit:masterfrom
srsutherland wants to merge 17 commits intonew-xkit:masterfrom
Conversation
AprilSylph
requested changes
Mar 13, 2019
AprilSylph
requested changes
Mar 18, 2019
AprilSylph
reviewed
Mar 19, 2019
AprilSylph
requested changes
Mar 19, 2019
AprilSylph
left a comment
AprilSylph
left a comment
There was a problem hiding this comment.
there's no need to leave comments on things that are either self-descriptive or obvious in meaning if you read the rest of the code
AprilSylph
requested changes
Mar 19, 2019
AprilSylph
requested changes
Mar 19, 2019
| }, | ||
|
|
||
| update_address: function() { | ||
| if (!XKit.extensions.addressbar.focus_only || document.hasFocus()) { |
There was a problem hiding this comment.
XKit.extensions.addressbar.focus_only doesn't exist; you meant XKit.extensions.addressbar.preferences.focus_only
| if (id !== null && id > 1) { | ||
| XKit.extensions.addressbar.replace_address(id); | ||
| } | ||
| return id; //unused/debug |
AprilSylph
requested changes
Mar 19, 2019
|
|
||
| update_address: function() { | ||
| if (!XKit.extensions.addressbar.focus_only || document.hasFocus()) { | ||
| //do nothing if you're not in focus |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Periodically updates the address bar with so that when refreshed, it returns to the last viewed post. Useful for tab crashes, resuming after restart, or with extensions like "The Great Suspender"
I'm not in love with the image, but I can't figure out how else to represent an address bar in a 64x64 square
