[XKit Preferences] Dark Mode Update 2#2024
Open
motackt wants to merge 4 commits intonew-xkit:masterfrom
Open
Conversation
nightpool
reviewed
Dec 23, 2020
Member
nightpool
left a comment
There was a problem hiding this comment.
Just a few quick notes—i don't have a lot of context on the current state of this code, i might not be the best person to review the rest of it
| --xkit-11-overlay: rgba(0,0,0,.11); | ||
| --xkit-22-overlay: rgba(0,0,0,.22); | ||
| --xkit-33-overlay: rgba(0,0,0,.33); | ||
| --xkit-44-overlay: rgba(0,0,0,.44); |
Member
There was a problem hiding this comment.
we're changing a lot of -shadow variable usage to -overlay in this PR. going forward, when would someone use -shadow vs using -overlay? is -shadow superfluous now?
Author
There was a problem hiding this comment.
I replaced all --shadow variables that do not describe a box-shadow or text-shadow to be an --overlay instead. I did this for two reasons:
- It's more descriptive this way.
--overlaydenotes something that will colour the entire element (ie hovering over a tab), whereas--shadowis now only used for shadows (ie text-shadows and box-shadows). - Dark Mode inverts the shadow colours (ie
--shadowgoes from black to white, and--white-shadowgoes from white to black). But not all shadows should be inverted, such as--shadow(which goes from black to white) because it creates white box-shadows which look really odd because they're not as intuitive as black shadows). But some overlays are still useful, so I split them up into--shadowand--overlayso that I can invert--overlaywhile turning off--shadow.
If you don't do this (ie no --overlay variables and invert every shadow), then you get this result:
Weird white box-shadows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Redid #1848 with the current master.
Original Description:
Put in some logic (using checkboxes) for the XKit Control Panel to:
Updated some class styles with items that weren't previously defined and so defaulted to black (not very clear against a dark background), and also added more variables because white box-shadows are not really a great design choice in dark themes.
As a bonus, changed the default and kernel extension icons to SVGs for crispness and space!