Skip to content

fix: correct reshare notification path#2425

Open
miaulalala wants to merge 1 commit intomasterfrom
fix/2277/correct-reshare-notification-path
Open

fix: correct reshare notification path#2425
miaulalala wants to merge 1 commit intomasterfrom
fix/2277/correct-reshare-notification-path

Conversation

@miaulalala
Copy link
Collaborator

Fixes #2277

@miaulalala
Copy link
Collaborator Author

/backport to stable33

@miaulalala
Copy link
Collaborator Author

/backport to stable32

@cypress
Copy link

cypress bot commented Mar 5, 2026

Activity    Run #3441

Run Properties:  status check passed Passed #3441  •  git commit ed98a60a7f: fix: correct reshare notification path
Project Activity
Branch Review fix/2277/correct-reshare-notification-path
Run status status check passed Passed #3441
Run duration 01m 59s
Commit git commit ed98a60a7f: fix: correct reshare notification path
Committer Anna
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 9
View all changes introduced in this branch ↗︎

@miaulalala
Copy link
Collaborator Author

/backport to stable33

@miaulalala
Copy link
Collaborator Author

/backport to stable32

Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the fix/2277/correct-reshare-notification-path branch from 64c4475 to d059f17 Compare March 11, 2026 21:58
@miaulalala miaulalala requested a review from artonge March 11, 2026 22:00
Copy link
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed that one

if ($sourceShare->getShareOwner() !== $sharedBy) {
$owner = $sourceShare->getShareOwner();
try {
$ownerNodes = $this->rootFolder->getUserFolder($owner)->getById($fileId);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$ownerNodes = $this->rootFolder->getUserFolder($owner)->getById($fileId);
$ownerNodes = $this->rootFolder->getUserFolder($owner)->getFirstNodeById($fileId);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in Activity when user shares nested folder with third user which is owned by admin

2 participants