Open
Conversation
Activity
|
||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
feat/405/auto-load-new-activities
|
| Run status |
|
| Run duration | 02m 00s |
| Commit |
|
| Committer | Anna |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
9
|
| View all changes introduced in this branch ↗︎ | |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
miaulalala
force-pushed
the
feat/405/auto-load-new-activities
branch
from
d9cdd6b to
4bbbbed
Compare
nextcloud-command
force-pushed
the
feat/405/auto-load-new-activities
branch
from
4bbbbed to
a4995e1
Compare
miaulalala
force-pushed
the
feat/405/auto-load-new-activities
branch
from
a4995e1 to
98fe59d
Compare
nextcloud-command
force-pushed
the
feat/405/auto-load-new-activities
branch
from
98fe59d to
ab0f2af
Compare
miaulalala
force-pushed
the
feat/405/auto-load-new-activities
branch
from
ab0f2af to
37693eb
Compare
nextcloud-command
force-pushed
the
feat/405/auto-load-new-activities
branch
from
37693eb to
7fdaa98
Compare
miaulalala
force-pushed
the
feat/405/auto-load-new-activities
branch
from
7fdaa98 to
3d0d63e
Compare
nextcloud-command
force-pushed
the
feat/405/auto-load-new-activities
branch
from
3d0d63e to
ebd2050
Compare
miaulalala
force-pushed
the
feat/405/auto-load-new-activities
branch
from
ebd2050 to
9ebdf54
Compare
Collaborator
Author
|
/compile amend |
Fix #405 Signed-off-by: Anna Larch <anna@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
feat/405/auto-load-new-activities
branch
from
9ebdf54 to
57f432c
Compare
Antreesy
reviewed
Mar 13, 2026
| const response = await ncAxios.get(generateOcsUrl('apps/activity/api/v2/activity/{filter}?format=json&previews=true&since={since}', { filter: props.filter, since })) | ||
| allActivities.value.push(...response.data.ocs.data.map((raw) => new ActivityModel(raw))) | ||
| const response = await ncAxios.get(generateOcsUrl('apps/activity/api/v2/activity/{filter}?format=json&previews=true&since={since}', { filter: props.filter, since }), { signal }) | ||
| if (signal.aborted) { |
Contributor
There was a problem hiding this comment.
Aborted signal should throw an error, I'm not sure it's gonna reach this code even. Please try to check whenever happening
| }) | ||
| } catch (error) { | ||
| if (axios.isCancel(error)) { | ||
| return |
Contributor
There was a problem hiding this comment.
This should be the correct handling for AbortController
| allActivities.value.unshift(...newActivities) | ||
| } else { | ||
| // Queue for the indicator so reading position is not disrupted | ||
| pendingNewActivities.value.unshift(...newActivities) |
Contributor
There was a problem hiding this comment.
If we're not at the top, prepending should not break the rendering, i think? so scroll position should remain the same
| * Prepend all queued activities and scroll back to the top | ||
| */ | ||
| function loadPendingActivities() { | ||
| allActivities.value.unshift(...pendingNewActivities.value) |
Contributor
There was a problem hiding this comment.
So button can just scroll to the top
Suggested change
| allActivities.value.unshift(...pendingNewActivities.value) |
| class="activity-app__new-activities-indicator" | ||
| type="button" | ||
| @click="loadPendingActivities"> | ||
| {{ n('activity', 'Load {count} new activity', 'Load {count} new activities', pendingNewActivities.length, { count: pendingNewActivities.length }) }} |
Contributor
There was a problem hiding this comment.
It's loaded already, just not shown, until you click. Maybe just:
Suggested change
| {{ n('activity', 'Load {count} new activity', 'Load {count} new activities', pendingNewActivities.length, { count: pendingNewActivities.length }) }} | |
| {{ t('activity', 'New activities') }} |
| </template> | ||
| </NcEmptyContent> | ||
| <div ref="container" class="activity-app__container"> | ||
| <button |
Contributor
There was a problem hiding this comment.
Suggested change
| <button | |
| <NcButton |
| @@ -26,6 +26,13 @@ | |||
| </template> | |||
| </NcEmptyContent> | |||
| <div ref="container" class="activity-app__container"> | |||
Contributor
There was a problem hiding this comment.
this can listen for @scroll event with a debounce and do this perhaps to hide the button?
const isNearTop = !container.value || container.value.scrollTop < 50
if (isNearTop && pendingNewActivities.value.length !== 0) {
pendingNewActivities.value = []
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #405
Screencast.from.2026-03-12.14-34-11.webm