Merged
Conversation
4 tasks
Member
|
@alperozturk96 While the coloring is correct now, where does the top-padding/margin come from between bar and search widget? |
Collaborator
Author
|
@AndyScherzinger Padding shouldn't be added on Android 14 and below. However, on Android 15 the new edge to edge support causes the status bar to overlap with our app’s content. To fix this, we need to use insets, but only for Android 15 and above. Padding value comes from WindowInsets class. No padding Android 15
With padding Android 15+
After this commit should be good for all Android versions. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
alperozturk96
commented
Jun 11, 2025
ui/src/main/java/com/nextcloud/android/common/ui/util/extensions/AppCompatActivityExtensions.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
…ns/AppCompatActivityExtensions.kt Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>
Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>
alperozturk96
force-pushed
the
feature/add-set-status-bar-color-functionality
branch
from
a2bc726 to
88654d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.