Skip to content

fix: connectivity service#16232

Open
alperozturk96 wants to merge 14 commits intomasterfrom
fix/connectivity-serv
Open

fix: connectivity service#16232
alperozturk96 wants to merge 14 commits intomasterfrom
fix/connectivity-serv

Conversation

@alperozturk96
Copy link
Copy Markdown
Collaborator

@alperozturk96 alperozturk96 commented Jan 2, 2026 •
edited
Loading

  • Tests written, or not not needed

Fixes: #14681

Deduplicates isNetworkAndServerAvailable logic

Implements ConnectivityManager.NetworkCallback for better network state listening

Removes deprecated logics

Adds better documentation

Adds exception handling for http call to prevent temporary issues thus we don't inform user with incorrect availability state

Uses for metered detection NET_CAPABILITY_NOT_METERED instead of NET_CAPABILITY_NOT_RESTRICTED

Removes network change receiver uses listener for much better reaction to network change

Converts to Kotlin

This was referenced Jan 2, 2026
Closed
Open
Open
@nextcloud nextcloud deleted a comment from github-actions bot Jan 27, 2026
@alperozturk96 alperozturk96 requested a review from ZetaTom January 27, 2026 10:56
ZetaTom

This comment was marked as resolved.

Sign in to view

@TheCrowned
Copy link
Copy Markdown

TheCrowned commented Feb 11, 2026

I gave this build a try - same error for me (both on upload, and on file listing).
The screenshot clearly shows network is available, both as WiFi and as data.
If it can help troubleshooting, upload works when I turn off WiFi and only leave data.
Screenshot_20260211-190409_Nextcloud QA

alperozturk96 and others added 8 commits March 31, 2026 12:50
@alperozturk96
fix: connectivity service impl
b8bd5dd 
# Conflicts:
#	app/src/main/java/com/nextcloud/client/network/ConnectivityServiceImpl.java
@alperozturk96
fix: connection service impl
5eec19b 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix: connection service tests
15044dd 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add wifi and metered check
950a374 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add logs
0bff3e4 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix tests
7559270 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fixes
020dfd1 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 @ZetaTom
Update app/src/main/java/com/nextcloud/client/network/ConnectivitySer…
7b9830e 
…vice.java

Co-authored-by: Tom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>
@alperozturk96 alperozturk96 force-pushed the fix/connectivity-serv branch from 4f091ab to 7b9830e Compare March 31, 2026 10:50
@alperozturk96
fix check
228bab7 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
Rename .java to .kt
14fe8a3 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
convert to kt
002540f 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix walled logic
1690059 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 added this to the Nextcloud App 33.1.0 milestone Mar 31, 2026
@alperozturk96
fix isNetworkAndServerAvailable logic
264613a 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@nextcloud nextcloud deleted a comment from github-actions bot Mar 31, 2026
@nextcloud nextcloud deleted a comment from github-actions bot Mar 31, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

APK file: https://github.com/nextcloud/android/actions/runs/23797153260/artifacts/6199195245
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
fix network change listener
7d56e29 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice3939
Correctness7070
Dodgy code231230
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1616
Total442441

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

APK file: https://github.com/nextcloud/android/actions/runs/23801699195/artifacts/6201251090
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

test-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16232-Unit-test-14-17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZetaTom ZetaTom ZetaTom left review comments

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 33.1.0

Development

Successfully merging this pull request may close these issues.

Upload Failure with "No Internet Connection" Message After Upgrading to Version 3.31.0 on Android App

3 participants

@alperozturk96 @TheCrowned @ZetaTom