Skip to content

fix(gradle): Fixed broken handling of test server and credentials#16422

Open
PhilLab wants to merge 1 commit intomasterfrom
ph/fix_build_arguments
Open

fix(gradle): Fixed broken handling of test server and credentials#16422
PhilLab wants to merge 1 commit intomasterfrom
ph/fix_build_arguments

Conversation

@PhilLab
Copy link
Contributor

@PhilLab PhilLab commented Jan 31, 2026

This was a refactoring error from a17e138

  • Tests written, or not not needed

This was a refactoring error from a17e138

Signed-off-by: Philipp Hasper <vcs@hasper.info>
@PhilLab
Copy link
Contributor Author

PhilLab commented Jan 31, 2026

@tobiasKaminsky

  1. For what its worth, I also had other build troubles caused by the Gradle update, but I didn't include them in the PR here, because their solution is less obvious: App build fails in encrypted Linux home dir since upgrade to AGP 9 #16421
  2. I am not exactly sure what it means that the PR I am hereby amending: chore(agp): Android Gradle plugin 9.0.0  #16306 , was added to the 3.36.0 milestone. Maybe the fix here should be in the milestone as well, if this is required to be part of the release code.

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16422.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.36.0 milestone Jan 31, 2026
@PhilLab
Copy link
Contributor Author

PhilLab commented Feb 14, 2026

@tobiasKaminsky this is needed to run automated tests locally, can you take a look?

@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants