591: Add groups to user info, with sections and using RecyclerView for future expandability

[penguin86]

Implementation of #591

Added groups and implemented sectioning in RecyclerView. Meant for adding further groups if needed in the future.
Based on the suggestions by Andy in #16767 (comment)

🖼️ Screenshots

🏚️ Before	🏡 After

🏁 Checklist

• Tests written, or not not needed

[alperozturk96]

Hello

Thank you for the PR.

[alperozturk96]

Why mDisplayList needs to have mutable list? Adapter should just display the list.

Also since this is a new class; mDisplayList can we rename it to the displayList?

[alperozturk96]

UserInfoDetailsItem this can be a data class. For item of the adapter better (so that we can compare easily if necessary) to use data class but it's a small thing.

[alperozturk96]

SectionedViewHolder? we can make this non-nullable.

[alperozturk96]

I prefer the extract item position logic to internal enum class.

private enum class ItemPosition {
  SINGLE, FIRST, MIDDLE, LAST;

  fun backgroundRes(): Int = when (this) {
    SINGLE -> R.drawable.rounded_corners_listitem_single_background
    FIRST -> R.drawable.rounded_corners_listitem_first_background
    LAST -> R.drawable.rounded_corners_listitem_last_background
    MIDDLE -> R.drawable.rounded_corners_listitem_center_background
  }
}

private fun resolvePosition(position: Int, count: Int): ItemPosition {
  val isFirst = (position == 0)
  val isLast = (position == count - 1)

  return when {
    isFirst && isLast -> ItemPosition.SINGLE
    isFirst -> ItemPosition.FIRST
    isLast -> ItemPosition.LAST
    else -> ItemPosition.MIDDLE
  }
}

So that we can have simpler onBindViewHolder

Usage:

val count = getItemCount(section)
val positionType = resolvePosition(relativePosition, count)
val uiHolder = holder as UserInfoSectionedViewHolder
val item = mDisplayList[section]?.get(relativePosition)

// Set background
uiHolder.binding.root.setBackgroundResource(
  positionType.backgroundRes()
)

[penguin86]

Hey @alperozturk96 , thank you for spotting the first 3 and thank you for the very sleek item type refactoring!
I committed them! Can I add your name on the contributor list in the adapter?

[alperozturk96]

Yes sure :)

[jancborchardt]

Very nice! :)

This is probably a follow-up and should be done separately, but it would be nice to also move it to be in line with how @AndyScherzinger did it for the Talk Android app: nextcloud/talk-android#5943

[penguin86]

Hey @jancborchardt , yes I think it's the final intent: in fact, this isn't my first implementation unfortunately, at first I completely missed the big picture 🤦‍♂️ : see comment #16767 (comment) in the, now closed, original PR.