Add a grid density setting - #17543
Open
sandbranch wants to merge 2 commits into
Open
sandbranch wants to merge 2 commits into
sandbranch wants to merge 2 commits into
Conversation
The number of grid columns came straight from the stored zoom preference and never looked at how wide the window actually is, so a phone in portrait and a tablet in landscape both showed the same three columns. onConfigurationChanged only ever clamped the count downwards, which meant rotating to landscape raised the limit but never added a column. Add a GridLayoutManager that works out its own column count from the width it is given during layout, and hand it a target column width instead of a column count. The target width is a dimension resource, so it can be adjusted per screen size later without touching this code. The width has to be read during layout. The display metrics are not a usable substitute: they describe the display rather than the space the list occupies, they are not yet meaningful while the view is being created, and during a rotation they can still describe the previous orientation, which produced a portrait grid laid out to the width of a landscape screen. Pinch to zoom keeps working and is still persisted. It now sets how large the cells are rather than a fixed column count, so a zoom level chosen in portrait carries over to landscape instead of being lost. Addresses part of the grid item of nextcloud#6769. Signed-off-by: David Sandquist <sandquist@gmail.com>
The grid cell size could only be changed by pinching the file list, which is easy to miss and awkward to land on a particular size. Add a density setting that writes the same stored value the pinch gesture uses, so the two stay in step and neither overrides the other. The options set how large the cells are rather than a fixed column count, because a column count that suits a tablet leaves a phone with cells too narrow to read. The file list only read that value while creating its view, so a density picked in the settings did not reach a list that was already open, and the list then wrote its stale value back when it saved its state. Read the value again on resume so the change takes effect on the way back. Signed-off-by: David Sandquist <sandquist@gmail.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The grid cell size can only be changed by pinching the file list, which is easy to miss and awkward to land on a particular size.
Fix
Add a density setting (Spacious / Default / Compact) under Settings → Files. It writes the same stored value the pinch gesture uses, so the two stay in step and neither overrides the other.
The options set how large the cells are rather than a fixed column count, deliberately: a column count that suits a tablet leaves a phone with cells too narrow to read, which is the problem #17542 fixes. Expressed as cell size, one stored value works correctly on every screen.
The file list only read that value while creating its view, so a density picked in the settings did not reach a list that was already open, and the list then wrote its stale value back when it saved its state. It now reads the value again on resume.
Testing
On a Samsung S23 the three options give 2 / 3 / 4 columns in portrait; on a Lenovo Tab P11 Pro (2nd gen) 4 / 5 / 7. Changing the setting takes effect on returning to the list, and the choice survives a restart.
New strings are added to
values/strings.xmlonly.