Skip to content

feat(direct-editing): add missing check - #17575

Open
alperozturk96 wants to merge 1 commit into
masterfrom
feat/use-direct-api
Open

alperozturk96 wants to merge 1 commit into
masterfrom
feat/use-direct-api

Conversation

@alperozturk96

Copy link
Copy Markdown
Collaborator

No description provided.

creator?.editor,
creator?.id,
template.title
template.id

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}

private fun creatorsActionsFromCollabora(): List<CreatorAction> {
// richdocuments 11+ serves its creators through DirectEditing, so the legacy entries would be duplicates.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alperozturk96 alperozturk96 linked an issue Sep 7, 2026 that may be closed by this pull request
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit bef75b2
Version 17575
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@alperozturk96 alperozturk96 added this to the Nextcloud App 35.0.1 milestone Sep 17, 2026
@alperozturk96

Copy link
Copy Markdown
Collaborator Author

/backport to stable-35.0.x

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness5858
Dodgy code186186
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3737
Security1818
Total360360

@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...android/ui/fragment/OCFileListBottomSheetDialog.kt 0.00% 2 Missing ⚠️
...p/src/main/java/com/nextcloud/utils/EditorUtils.kt 0.00% 1 Missing ⚠️
.../android/ui/dialog/ChooseTemplateDialogFragment.kt 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement direct editing API

1 participant