fix: edit simple buttons running away#8533
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Grigory V <scratchx@gmx.com>
GVodyanov
force-pushed
the
fix/edit-simple-buttons
branch
from
b74033e to
06ef8cf
Compare
SebastianKrupinski
left a comment
SebastianKrupinski
left a comment
There was a problem hiding this comment.
Tested works.
In general binding the pop over to the body instead of the anchor seems to fix unknown size issue when calculating the height, very well.
Don't remember the reasoning for not doing this in the first place, at the moment
| if (this.popoverReady) { | ||
| // Popover is already visible — leave position and size completely alone. | ||
| // Content changes (add attendee, toggle all-day, etc.) are handled by | ||
| // the inner element's flex layout: the content area scrolls while the | ||
| // footer stays anchored at the bottom. | ||
| return | ||
| } |
There was a problem hiding this comment.
Remove this.
If you are editing at the bottom and you add an attendee, they should be displayed if there is space
|
|
||
| // Get current popover element dimensions (reading offsetHeight forces a reflow) | ||
| const naturalHeight = existingPopover?.offsetHeight || 0 | ||
| const estimatedHeight = Math.max(naturalHeight, 420) |
There was a problem hiding this comment.
Change the minimum height to 200. This prevents excessive spacing when clicking on object at the very bottom.
| clearTimeout(this.resizeTimeout) | ||
| } | ||
| this.resizeTimeout = setTimeout(() => { | ||
| this.repositionPopover() |
There was a problem hiding this comment.
Add true to the repositionPopover(true) so that window resizing moves the editor.
I don't remember why this was changed.
| // background image is set), which turns it into a containing block for | ||
| // fixed descendants and clips them via overflow:hidden — cutting off the | ||
| // footer / save-button row. | ||
| if (this.$el.parentElement === document.body) { |
There was a problem hiding this comment.
Since we are no longer binding the popover to the anchor element, it should to be removed from Calendar.vue
2 participants
Fix #8523
Fixes:
Makes it so that the buttons are anchored to the bottom of the component so they are always accessible. If there is not enough space to display everything in the component you scroll down to the attendees.
🤖 AI (if applicable)