-
Notifications
You must be signed in to change notification settings - Fork 327
feat: add card dependencies #7879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| <?php | ||
|
|
||
| /** | ||
| * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| declare(strict_types=1); | ||
| namespace OCA\Deck\Migration; | ||
|
|
||
| use Closure; | ||
| use OCP\Migration\IOutput; | ||
| use OCP\Migration\SimpleMigrationStep; | ||
|
|
||
| class Version11002Date20260410000000 extends SimpleMigrationStep { | ||
| public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) { | ||
| $schema = $schemaClosure(); | ||
|
|
||
| if ($schema->hasTable('deck_cards')) { | ||
| $table = $schema->getTable('deck_cards'); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm curios about the thought process of storing related cards as json field. Why not have it as an actual db relation so we can have both |
||
| if (!$table->hasColumn('dependent_cards')) { | ||
| $table->addColumn('dependent_cards', 'text', [ | ||
| 'notnull' => false, | ||
| ]); | ||
| } | ||
| } | ||
| return $schema; | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we don't implement it yet we should throw a not implement exception here