Repository navigation
fix(search): load the deck stylesheet on the full text search page - #8560
Merged
Merged
Conversation
DeckProvider still pointed the full text search template at css/icons.css, which was removed in 2022. Since fulltextsearch loads provider stylesheets again, the page logs a 404 and a failed stylesheet load on every visit. Use the deck stylesheet that the app ships. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Contributor
Author
|
/backport to stable35 |
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
grnd-alt
approved these changes
Oct 19, 2026
Contributor
|
🐢 Performance warning. |
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the Full text search page, every visit logs a 404 for
/apps/deck/css/icons.cssand a failed stylesheet load.DeckProvider::getSearchTemplate()still points aticons, which was removed in 2022, and fulltextsearch loads provider stylesheets again since 33.0.2. This uses thedeckstylesheet the app ships.Seen in a customer setup on Nextcloud 33 (Deck 1.17.6, Full text search 33.0.3) and reproduced on 33.0.9. With
deck, the stylesheet loads with 200 and the errors are gone.Needs backports to stable35, stable34 and stable33.
Checklist
🤖 AI (if applicable)