feat(desktop/appimage): use KDE Craft and their binary cache to get Qt #877
+253
−148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
force-pushed
the
desktop/AppImageBuiltWithKdeCraft
branch
from
cbc7322 to
ab558e0
Compare
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
desktop/AppImageBuiltWithKdeCraft
branch
from
eacf2b9 to
92d5067
Compare
nilsding
reviewed
Jan 8, 2026
Comment on lines
+27
to
+28
| gcc-toolset-14 \ | ||
| gcc-toolset-14-libatomic-devel \ |
Member
There was a problem hiding this comment.
this needs to be adapted in the build-appimage script as well:
https://github.com/nextcloud/desktop/blob/a8da938aeb43428993242bf4a5a0c991c724381c/admin/linux/build-appimage.sh#L26-L29
ensure proper search path for pkgconf by setting PKG_CONFIG_PATH env variable before calls to craft will enable the build to find libraries provided by the host system Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Contributor
Author
|
we also need a way to build the cache itself to be uploaded on our download server |
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.