Fix mistral for pdf documents - #424
Open
lukasdotcom wants to merge 1 commit into
Open
lukasdotcom wants to merge 1 commit into
lukasdotcom wants to merge 1 commit into
Conversation
lukasdotcom
force-pushed
the
fix-mistral
branch
from
August 7, 2026 16:30
eab99c7 to
39bd8d3
Compare
edward-ly
requested changes
Sep 14, 2026
edward-ly
left a comment
edward-ly
left a comment
Contributor
There was a problem hiding this comment.
Would you be able to split the refactors and the actual fix into separate commits? That would make things easier to review.
lukasdotcom
force-pushed
the
fix-mistral
branch
2 times, most recently
from
September 14, 2026 19:18
1269c8c to
e0b0249
Compare
Member
Author
Rebased it and split it into two commits. Edit: Due to #431 the refactor isn't needed anymore. |
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
lukasdotcom
force-pushed
the
fix-mistral
branch
from
September 15, 2026 13:12
e0b0249 to
3b7e484
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also had an llm refactor the isUsing functions into openAiSettingsService so there weren't circular dependencies. Thanks @cbcoutinho for finding this issue originally.
🤖 AI (if applicable)