fix(ci): disable OCM signed requests for federated share tests#5799
Draft
elzody wants to merge 2 commits into
Draft
fix(ci): disable OCM signed requests for federated share tests#5799elzody wants to merge 2 commits into
elzody wants to merge 2 commits into
Conversation
The federated editing Cypress tests were failing because self-federated OCM share notifications were being rejected due to RFC 9421 signature verification failures. The CI server runs over plain HTTP, but OCMSignatoryManager::fetchJwks() hardcodes https:// for JWKS URLs, causing the fetch to fail. This results in confirmSignedOrigin() throwing "instance is supposed to sign its request" and returning HTTP 400, so the pending share is never created for the recipient and document.odt never appears in the files list. Set ocm_signed_request_disabled=true to bypass the signing requirement in the HTTP test environment, where inter-server TLS is unavailable. Also add an early assertion in shareFileToRemoteUser() so any future federation setup failures produce a clear Cypress error rather than silently cascading into a timeout on cy.openFile(). Assisted-by: ClaudeCode:claude-sonnet-4-6 Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
…abled config:app:set does not accept --type bool; pass --value="true" instead, which getValueBool() resolves correctly. Assisted-by: ClaudeCode:claude-sonnet-4-6 Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The federated editing Cypress tests were failing because self-federated OCM share notifications were being rejected due to RFC 9421 signature verification failures. The CI server runs over plain HTTP, but OCMSignatoryManager::fetchJwks() hardcodes https:// for JWKS URLs, causing the fetch to fail. This results in confirmSignedOrigin() throwing "instance is supposed to sign its request" and returning HTTP 400, so the pending share is never created for the recipient and document.odt never appears in the files list.
Set ocm_signed_request_disabled=true to bypass the signing requirement in the HTTP test environment, where inter-server TLS is unavailable. Also add an early assertion in shareFileToRemoteUser() so any future federation setup failures produce a clear Cypress error rather than silently cascading into a timeout on cy.openFile().
Assisted-by: ClaudeCode:claude-sonnet-4-6
Summary
TODO
Checklist