Skip to content

chore: fix strict psalm and rector#60012

Merged
susnux merged 4 commits intomasterfrom
chore/rector-psalm
Apr 30, 2026
Merged

chore: fix strict psalm and rector#60012
susnux merged 4 commits intomasterfrom
chore/rector-psalm

Conversation

@susnux
Copy link
Copy Markdown
Contributor

@susnux susnux commented Apr 30, 2026

Summary

  • As cherry picked psalm changes to also cover tests and make use of the phpunit plugin.
  • Fix the strict rector rules to properly autoload OCP otherwise it does not know about those interface¹
  • Fix the strict psalm rules for the same reason to make them aware of our OC and OCP code
  • Apply the changes and committed the results

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@susnux susnux requested a review from a team as a code owner April 30, 2026 09:34
@susnux susnux added 3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Apr 30, 2026
@susnux susnux added this to the Nextcloud 34 milestone Apr 30, 2026
@susnux susnux requested review from Altahrim, ArtificialOwl, leftybournes, nickvergessen, provokateurin and salmart-dev and removed request for a team April 30, 2026 09:34
Comment thread vendor-bin/psalm/composer.json
provokateurin and others added 4 commits April 30, 2026 12:35
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the chore/rector-psalm branch from 97062fa to 75273a6 Compare April 30, 2026 10:35
@susnux susnux requested a review from provokateurin April 30, 2026 10:35
@susnux susnux merged commit fdbd39a into master Apr 30, 2026
237 of 245 checks passed
@susnux susnux deleted the chore/rector-psalm branch April 30, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants