Skip to content

refactor(Fetcher): properly type AppStore fetcher#60016

Merged
susnux merged 1 commit intomasterfrom
fix/app-types
Apr 30, 2026
Merged

refactor(Fetcher): properly type AppStore fetcher#60016
susnux merged 1 commit intomasterfrom
fix/app-types

Conversation

@susnux
Copy link
Copy Markdown
Contributor

@susnux susnux commented Apr 30, 2026

As this is unrelated to that PR lets properly type it first here.

Note regarding "AI assisted":
I used copilot to convert the app-discover json schema to type annotations.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@susnux susnux added this to the Nextcloud 34 milestone Apr 30, 2026
@susnux susnux requested review from a team and provokateurin as code owners April 30, 2026 11:59
@susnux susnux added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Apr 30, 2026
@susnux susnux removed the request for review from a team April 30, 2026 11:59
@susnux susnux added the ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) label Apr 30, 2026
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Copy link
Copy Markdown
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

@susnux susnux merged commit 9a5ff61 into master Apr 30, 2026
205 of 213 checks passed
@susnux susnux deleted the fix/app-types branch April 30, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants