feat: allow loading external storage config values from file#60743
Open
icewind1991 wants to merge 1 commit into
Open
feat: allow loading external storage config values from file#60743icewind1991 wants to merge 1 commit into
icewind1991 wants to merge 1 commit into
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
ArtificialOwl,
artonge,
provokateurin and
salmart-dev
and removed request for
a team
artonge
reviewed
May 27, 2026
artonge
approved these changes
Jun 2, 2026
| @@ -40,6 +41,11 @@ protected function configure(): void { | |||
| 'value', | |||
| InputArgument::OPTIONAL, | |||
| 'value to set the config option to, when no value is provided the existing value will be printed' | |||
Member
There was a problem hiding this comment.
Suggested change
| 'value to set the config option to, when no value is provided the existing value will be printed' | |
| 'value to set the config option to; when omitted, the existing value is printed; with --value-from-file, this is treated as a file path' |
| 'value-from-file', | ||
| null, | ||
| InputOption::VALUE_NONE, | ||
| 'read the value from the file provided' |
Member
There was a problem hiding this comment.
Suggested change
| 'read the value from the file provided' | |
| 'treat the value argument as a file path and read the config value from that file' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some values like ssh keys can be very hard to pass trough the command line because of the special characters in the value. Loading the value from a file instead can make it much easier to set these options.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)