fix(settings): correct heading order in account management sidebar#61505
Merged
Conversation
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
commented
Jun 22, 2026
| :disabled="loadingAddGroup" | ||
| :aria-label="loadingAddGroup ? t('settings', 'Creating group…') : t('settings', 'Create group')" | ||
| force-menu | ||
| is-heading |
Contributor
Author
There was a problem hiding this comment.
key change: is-heading dropped
pringelmann
requested review from
nfebe,
sorbaugh and
susnux
and removed request for
a team
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable32 |
susnux
reviewed
Jun 22, 2026
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
force-pushed
the
fix/settings-group-nav-heading-order
branch
from
b6b5b47 to
122c253
Compare
susnux
approved these changes
Jun 22, 2026
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
susnux
approved these changes
Jun 23, 2026
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The account management page renders the sidebar "Groups" caption as an
<h2>. The navigation comes before the main content in the DOM, so that<h2>lands ahead of the page's<h1>(the view title, e.g. "Account group: X"), and the heading outline reads h2 then h1. That fails WCAG 1.3.1 / BITV 9.1.3.1a (headings out of order).This moves the "Groups" caption inside the
NcAppNavigationListand dropsis-heading, so it's a list caption instead of a heading. The page's only heading is then the content<h1>, a single correctly-nested outline. The group list keeps its visible label, it's just no longer exposed as a heading.Screenshots from HeadingsMap:
TODO
Checklist
3. to review, feature: settings)