Skip to content

Fix the ScanFiles job to not trigger scans of root directory for every single user #61511

Open
akhil1508 wants to merge 1 commit into
nextcloud:masterfrom
Murena-SAS:dev/dont-scan-appdata
Open

Fix the ScanFiles job to not trigger scans of root directory for every single user #61511
akhil1508 wants to merge 1 commit into
nextcloud:masterfrom
Murena-SAS:dev/dont-scan-appdata

Conversation

@akhil1508

Copy link
Copy Markdown
Contributor

Summary

  • When '' is passed getMounts returns home::username and local:/var/www/data mounts and both of these get scanned
  • This manages to scan the appdata folder too for each and every user adding significant delays to a job that should be quick for 500 users at one time
  • This method seems the same as the one used in occ files:scan username --unscanned and there the path resolves to /username and not ''

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@akhil1508 akhil1508 requested a review from a team as a code owner June 22, 2026 17:58
@akhil1508 akhil1508 requested review from Altahrim, ArtificialOwl, come-nc and leftybournes and removed request for a team June 22, 2026 17:58
@akhil1508 akhil1508 force-pushed the dev/dont-scan-appdata branch from 2efa616 to 9592cdb Compare June 22, 2026 17:58

@provokateurin provokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@provokateurin

Copy link
Copy Markdown
Member

/backport to stable34

@provokateurin

Copy link
Copy Markdown
Member

/backport to stable33

@provokateurin

Copy link
Copy Markdown
Member

/backport to stable32

@akhil1508 akhil1508 force-pushed the dev/dont-scan-appdata branch from 9592cdb to 72f63dd Compare June 23, 2026 08:03
@provokateurin

Copy link
Copy Markdown
Member

@akhil1508 please don't update the branch, unless there are actual conflicts. This requires us to re-approve and restart CI, resulting in delays for merging the PR.

@akhil1508

Copy link
Copy Markdown
Contributor Author

please don't update the branch, unless there are actual conflicts. This requires us to re-approve and restart CI, resulting in delays for merging the PR.

@provokateurin got it, apologies!

@come-nc come-nc added this to the Nextcloud 35 milestone Jun 23, 2026
@come-nc come-nc added the 3. to review Waiting for reviews label Jun 23, 2026
@CarlSchwan CarlSchwan enabled auto-merge June 23, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ScanFiles job triggers a scan of the root storage for each and every user

4 participants