Skip to content

Block {DAV:} and ocs namespace properties from custom properties table. #61512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
icewind1991 wants to merge 2 commits into
base: master
Choose a base branch
from
+15 −0
Open

Block {DAV:} and ocs namespace properties from custom properties table. #61512

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1defaf2
perf: block all '{DAV:}' custom properties except for 'displayname'
icewind1991 Jun 22, 2026
7cba53a
perf: block all '{http://open-collaboration-services.org/ns}' custom …
icewind1991 Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions apps/dav/lib/DAV/CustomPropertiesBackend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,15 @@ class CustomPropertiesBackend implements BackendInterface {
'{http://owncloud.org/ns}enabled',
];

/**
* Allowed properties for the dav namespace, all other properties in the namespace are ignored
*
* @var string[]
*/
private const ALLOWED_DAV_PROPERTIES = [
'{DAV:}displayname',
];

/**
* Properties set by one user, readable by all others
*
Expand Down Expand Up @@ -275,6 +284,12 @@ private function isPropertyAllowed(string $property): bool {
if (in_array($property, self::IGNORED_PROPERTIES)) {
return false;
}
if (str_starts_with($property, '{http://open-collaboration-services.org/ns}')) {
return false;
}
if (str_starts_with($property, '{DAV:}')) {
return in_array($property, self::ALLOWED_DAV_PROPERTIES);
}
if (str_starts_with($property, '{http://owncloud.org/ns}') || str_starts_with($property, '{http://nextcloud.org/ns}')) {
return in_array($property, self::ALLOWED_NC_PROPERTIES);
}
Expand Down
Loading