perf: avoid DIing IRootFolder at every shared storage init#61530
Open
salmart-dev wants to merge 1 commit into
Open
perf: avoid DIing IRootFolder at every shared storage init#61530salmart-dev wants to merge 1 commit into
salmart-dev wants to merge 1 commit into
Conversation
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
salmart-dev
force-pushed
the
fix/rootfolder-sharedstorage-init
branch
from
1b68a0e to
93a4f88
Compare
Contributor
Author
|
/backport to stable34 |
salmart-dev
requested review from
Altahrim,
ArtificialOwl,
come-nc and
icewind1991
and removed request for
a team
CarlSchwan
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
initfunction inSharedStoragecan be called thousand times in servers with many shares, avoid callingServer::get(IRootFolder::class)each time and inject it once per call ofMountProvider.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)