fix(dav): fail propfind for unavailable mounts - #63169
Open
gitedmond wants to merge 2 commits into
Open
Conversation
Assisted-by: Codex:GPT-5 Signed-off-by: Edmond <edmnd@users.noreply.github.com>
gitedmond
marked this pull request as ready for review
August 12, 2026 01:06
gitedmond
requested review from
leftybournes,
provokateurin,
salmart-dev and
sorbaugh
and removed request for
a team
August 12, 2026 01:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an external mount becomes unavailable,
View::getDirectoryContent()currently omits that mount and continues. For WebDAVPROPFINDrequests, this can produce a successful207 Multi-Statusresponse containing an incomplete directory listing. Synchronization clients may interpret the missing mount or its files as server-side deletions.This adds an opt-in strict directory-listing mode while preserving the existing lenient behavior for other callers. A Files-specific PROPFIND plugin performs strict validation before SabreDAV starts streaming the multistatus response. If an unavailable mount would make the listing incomplete, the request now returns
503 Service Unavailable.Validation
The original and fixed behavior were reproduced using a live SMB external-storage backend:
207while omitting the unavailable mount503without emitting an incomplete multistatus responseThe following checks passed:
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)
Codex using GPT-5.6 sol assisted with issue research, code analysis, implementation, testing, environment setup, reproduction, and validation. The commit records this with an
Assisted-by: Codex:GPT-5trailer.