Skip to content

fix(preview): execute PreviewMapper::deleteAll() - #63247

Open
joshtrichards wants to merge 1 commit into
masterfrom
jtr/fix-previewMapper-deleteAll-execute
Open

fix(preview): execute PreviewMapper::deleteAll()#63247
joshtrichards wants to merge 1 commit into
masterfrom
jtr/fix-previewMapper-deleteAll-execute

Conversation

@joshtrichards

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

Fix PreviewMapper::deleteAll() so that it actually executes the generated DELETE statement. ;-)

Production code, such as preview cleanup currently removes previews individually through PreviewService::deleteAll() (which uses PreviewMapper::delete() for each one), but this mapper method is used by tests (in tearDown()) and is a no-op for any future callers.

TODO

  • Backport to >=v33

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added this to the Nextcloud 35 milestone Aug 14, 2026
@joshtrichards
joshtrichards requested a review from a team as a code owner August 14, 2026 15:43
@joshtrichards
joshtrichards requested review from icewind1991, leftybournes and provokateurin and removed request for a team August 14, 2026 15:43
@joshtrichards joshtrichards added bug 3. to review Waiting for reviews feature: previews and thumbnails ⚠️ risk: low Unlikely to cause meaningful regressions; limited runtime or compatibility impact. labels Aug 14, 2026
@joshtrichards

Copy link
Copy Markdown
Member Author

/backport to stable34

@joshtrichards

Copy link
Copy Markdown
Member Author

/backport to stable33

@joshtrichards joshtrichards added the ⏱️ review-effort: quick Can usually be reviewed from the diff and nearby context; targeted validation may be sufficient. label Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request bug feature: previews and thumbnails ⏱️ review-effort: quick Can usually be reviewed from the diff and nearby context; targeted validation may be sufficient. ⚠️ risk: low Unlikely to cause meaningful regressions; limited runtime or compatibility impact.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant