Skip to content

fix(jobs): don't overwrite the --stop_after baseline in background-job:worker #63297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaenda wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

fix(jobs): don't overwrite the --stop_after baseline in background-job:worker #63297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/Command/Background/JobWorker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,9 @@ protected function execute(InputInterface $input, OutputInterface $output): int
memory_reset_peak_usage();
$jobClassId = $this->jobClassesRegistry->getId($jobClassName);
$jobRunId = $this->jobRuns->started($jobClassId);
$startTime = microtime(true);
$jobStartTime = microtime(true);
$job->start($this->jobList);
$timeSpent = microtime(true) - $startTime;
$timeSpent = microtime(true) - $jobStartTime;
$jobMemoryPeak = memory_get_peak_usage();
// TODO Job failure will never be catched here because exceptions are catched within $job->start method
// The error will only be visible in server logs.
Expand Down
Loading