[stable34] chore(deps): bump @nextcloud/dialogs from 7.4.1 to 7.5.0 in /build/frontend-legacy

[dependabot]

Bumps @nextcloud/dialogs from 7.4.1 to 7.5.0.

Release notes

Sourced from @​nextcloud/dialogs's releases.

v7.5.0

v7.5.0

Notes

This version include some reworked - and accessible - toast notifications. Those new toast messages will be displayed on the bottom start of the page, this is by design and not a bug.

Added

• feat: toast timeout configuration #2539 (kristian-zendato)
• feat: accessible toast and drop toastify #2324 (skjnldsv)

Fixed

• Simplify the file conflict dialog #2540 (jancborchardt)

Changelog

Sourced from @​nextcloud/dialogs's changelog.

v7.5.0

Notes

This version include some reworked - and accessible - toast notifications. Those new toast messages will be displayed on the bottom start of the page, this is by design and not a bug.

Added

• feat: toast timeout configuration #2539 (kristian-zendato)
• feat: accessible toast and drop toastify #2324 (skjnldsv)

Fixed

• Simplify the file conflict dialog #2540 (jancborchardt)

Commits

• dec5ccf Merge pull request #2579 from nextcloud-libraries/chore/prepare-rel
• 395a38f chore: add note about toasts
• 6d2dd27 chore: prepare v7.5.0
• 4030af4 Merge pull request #2575 from nextcloud-libraries/dependabot/npm_and_yarn/mai...
• a07e474 chore(deps-dev): bump the vitest group with 2 updates
• 40d0492 Merge pull request #2565 from nextcloud-libraries/automated/noid/main-fix-npm...
• 20df0f0 Merge pull request #2539 from nextcloud-libraries/feat/timeout-configuration
• f4e2981 chore: adjust to comply with ESLint
• c8e9080 feat: toast timeout configuration
• 19882e5 Merge pull request #2574 from nextcloud-libraries/translations_441be4f7621043...
• Additional commits viewable in compare view

[AndyScherzinger]

/compile

[AndyScherzinger]

Analysis: TypeError: Cannot read properties of undefined (reading 'nodeType') after @nextcloud/dialogs 7.4.1 → 7.5.0

Root cause

@nextcloud/dialogs 7.5.0, lib/toast.ts:

296:  data = new DOMParser().parseFromString(data, 'text/html').body.innerText
...
311:  const text = getAnnouncementText(data, opts.isHTML)
270:  return getVisibleText(data)           // ← data is undefined
244:  if (node.nodeType === Node.TEXT_NODE) // ← throws

jsdom has never implemented HTMLElement.innerText — it is not even on the prototype. Verified against jsdom 30 (and 29.1.1 is what this repo locks):

jsdom version: 30.0.1
innerText   : undefined
textContent : "hi there"
in prototype: false

So at line 296 data becomes undefined. getAnnouncementText(undefined, false) fails the typeof data === 'string' guard, falls through to getVisibleText(undefined), and dereferences .nodeType. The exact error was reproduced in isolation with the 7.5.0 code path.

Why the bump surfaced it (and why it is still non-breaking)

7.4.1 had the same innerText defect — line 122: element.innerHTML = data; data = element.innerText. Under jsdom the toast message was already undefined there; it was just handed to Toastify as text and rendered harmlessly. 7.5.0 added the new persistent aria-live announcement path (getAnnouncementText / getVisibleText), which now dereferences that value.

The bump did not introduce the defect — it converted a pre-existing silent one into a throw. The semver-minor classification is accurate for browser use.

Not an issue outside tests

In real browsers innerText exists. The DOMParser document has no browsing context, so nothing in it is "being rendered", and per the HTML spec innerText then returns the same value as textContent. The strip works correctly in every browser. No user-facing regression — jsdom-only.

Why this particular spec fails

Two latent issues in our own code line up:

1. apps/files/src/composables/useHotKeys.ts:36 — useHotKey(key, () => executeAction(action), …). The returned promise is never awaited or caught, so anything escaping executeAction becomes an unhandled rejection (hence processTicksAndRejections in the trace).
2. useHotKeys.spec.ts does vi.mock('../actions/deleteAction.ts', { spy: true }), which keeps the real exec. In the 'registeres actions' test the call stack contains keydown, so exec enters askConfirmation(...) and throws under jsdom. executeAction catches it, logs, and calls showError at apps/files/src/utils/actionUtils.ts:75 — inside the catch. showError itself then throws, escapes the catch, and there is no handler anywhere up the chain.

Recommended fixes

Upstream (the real fix) — nextcloud-libraries/nextcloud-dialogs: use textContent instead of innerText at toast.ts:296, and/or guard getVisibleText against a nullish node. 7.5.0 is currently the latest published version, so no released fix exists yet.

In this repo, to unblock the bump — add an innerText polyfill to build/frontend-legacy/__tests__/mock-window.js:

Object.defineProperty(HTMLElement.prototype, 'innerText', {
      get() { return this.textContent },
      set(value) { this.textContent = value },
      configurable: true,
})

This also fixes the latent 7.4.1 breakage where toasts silently announced undefined in tests.

Worth doing regardless — attach a .catch() in useHotKeys.ts:36 so a failing action can never produce an unhandled rejection.

Related

build/frontend also runs on jsdom and pulls dialogs from the root package.json (still ^7.4.1). The equivalent dependabot PR there will hit the identical failure, so the polyfill likely belongs in both test setups.

Note: if this is headed for the PR thread or an upstream issue, our AGENTS.md requires review comments and issue reports to be in your own words — worth rewording rather than pasting verbatim.

[AndyScherzinger]

@dependabot recreate

[AndyScherzinger]

@dependabot rebase

[AndyScherzinger]

@dependabot rebase