Take mount name into account when searching by filename. - #64152
Merged
Merged
Conversation
icewind1991
requested review from
Altahrim,
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
September 9, 2026 17:19
icewind1991
force-pushed
the
search-mount-name
branch
from
September 11, 2026 13:42
b1c53e1 to
625a721
Compare
icewind1991
force-pushed
the
search-mount-name
branch
2 times, most recently
from
September 21, 2026 15:21
73e2bf0 to
4b612c3
Compare
provokateurin
approved these changes
Sep 22, 2026
icewind1991
force-pushed
the
search-mount-name
branch
from
September 22, 2026 11:20
116c8ca to
7246c09
Compare
CarlSchwan
approved these changes
Sep 22, 2026
salmart-dev
reviewed
Sep 22, 2026
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
…o the list of root ids Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
search-mount-name
branch
from
September 22, 2026 15:30
7246c09 to
c0a152b
Compare
Member
Author
|
/backport to stable35 |
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
3 tasks
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, searching only takes the filename as it exists in the filecache into account. This doesn't (always) work for the root of mounts though.
Renamed shares and the root of groupfolder/external storages aren't matched because their name in the filesystem isn't the same as the name for their cache entry.
This solves that by also taking the name of the mountpoint into account when searching
regex_substringto the query buildermount_path_nameas a field in the filecache search, which gets transformed to a substring ofmount_pathmount_path_nameChecklist
3. to review, feature component)stable32)AI (if applicable)