Skip to content

feat: Allow user-level sender addresses via mail provided #64395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahujadivyam wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: Allow user-level sender addresses via mail provided #64395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
db23591
feat(sharebymail): allow user-level sender addresses via Mail Provide…
ahujadivyam Sep 22, 2026
198e859
fix(sharebymail): strictly type findMailService and fix user mock error
ahujadivyam Sep 22, 2026
10147bf
fix(sharebymail): strictly typehint mail service as IMessageSend and …
ahujadivyam Sep 22, 2026
0035814
refactor(sharebymail): factor out mail provider sending and template …
ahujadivyam Sep 22, 2026
ace1d9e
style(sharebymail): fix trailing whitespace
ahujadivyam Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apps/sharebymail/lib/Settings/Admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ public function __construct(
public function getForm() {
$this->initialState->provideInitialState('sendPasswordMail', $this->settingsManager->sendPasswordByMail());
$this->initialState->provideInitialState('replyToInitiator', $this->settingsManager->replyToInitiator());
$this->initialState->provideInitialState('useUserEmail', $this->settingsManager->useUserEmail());

Util::addStyle('sharebymail', 'admin-settings');
Util::addScript('sharebymail', 'admin-settings');
Expand Down Expand Up @@ -67,6 +68,7 @@ public function getAuthorizedAppConfig(): array {
'sharebymail' => [
'sendpasswordmail',
'replyToInitiator',
'useUserEmail',
],
];
}
Expand Down
18 changes: 18 additions & 0 deletions apps/sharebymail/lib/Settings/SettingsManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ class SettingsManager {

private $replyToInitiatorDefault = 'yes';

private $useUserEmailDefault = 'no';

public function __construct(
private IConfig $config,
) {
Expand All @@ -41,4 +43,20 @@ public function replyToInitiator(): bool {
$replyToInitiator = $this->config->getAppValue('sharebymail', 'replyToInitiator', $this->replyToInitiatorDefault);
return $replyToInitiator === 'yes';
}

/**
* Should share-by-mail emails be sent using the user's personal email
* address (via Mail Provider) instead of the global system email address.
*
* When enabled and a Mail Provider is available for the user, share
* notification emails will be sent from the user's own address, similar
* to how calendar invitations work.
*
* @return bool
* @psalm-suppress DeprecatedMethod
*/
public function useUserEmail(): bool {
$useUserEmail = $this->config->getAppValue('sharebymail', 'useUserEmail', $this->useUserEmailDefault);
return $useUserEmail === 'yes';
}
}
Loading