feat: Add IAccountScopedSearchProvider - #64491
Open
CarlSchwan wants to merge 5 commits into
Open
CarlSchwan wants to merge 5 commits into
CarlSchwan wants to merge 5 commits into
Conversation
CarlSchwan
force-pushed
the
carl/investigation-api
branch
3 times, most recently
from
September 21, 2026 12:20
789c118 to
e9d774b
Compare
CarlSchwan
marked this pull request as ready for review
September 21, 2026 12:22
CarlSchwan
requested review from
a team,
ChristophWurst,
SebastianKrupinski,
hamza221 and
tcitworld
as code owners
September 21, 2026 12:22
CarlSchwan
requested review from
Altahrim,
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
September 21, 2026 12:22
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
carl/investigation-api
branch
from
September 21, 2026 13:12
e9d774b to
313d1c7
Compare
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
carl/investigation-api
branch
from
September 21, 2026 14:27
313d1c7 to
4c0220e
Compare
icewind1991
reviewed
Sep 21, 2026
| #[AsCommand( | ||
| name: 'search:providers', | ||
| description: 'List the registered account-scoped search providers and the fields each one can be searched on', | ||
| help: 'This command is experimental: it queries NCU\Search\IAccountScopedSearchProvider, which is itself experimental and may still change or be removed.', |
Member
There was a problem hiding this comment.
having the technical gobbledygook in admin facing strings is not great.
icewind1991
reviewed
Sep 21, 2026
| /** | ||
| * @psalm-import-type DeclarativeSettingsFormField from \OCP\Settings\IDeclarativeSettingsForm | ||
| */ | ||
| class AccountScopedSearchProvider implements IAccountScopedSearchProvider { |
Member
There was a problem hiding this comment.
Please use distinct class names so we don't end up with N different AccountScopedSearchProvider classes in different namespaces
icewind1991
reviewed
Sep 21, 2026
Comment on lines
+83
to
+90
| $fields = [ | ||
| ['id' => 'name', 'title' => $this->l10n->t('Name'), 'type' => 'text', 'default' => ''], | ||
| ['id' => 'path', 'title' => $this->l10n->t('Path'), 'type' => 'text', 'default' => ''], | ||
| ['id' => 'mimetype', 'title' => $this->l10n->t('File type'), 'type' => 'text', 'default' => ''], | ||
| ['id' => 'size', 'title' => $this->l10n->t('Size'), 'type' => 'number', 'default' => 0], | ||
| ['id' => 'modified', 'title' => $this->l10n->t('Modified'), 'type' => 'number', 'default' => 0], | ||
| ['id' => 'created', 'title' => $this->l10n->t('Created'), 'type' => 'number', 'default' => 0], | ||
| ]; |
Member
There was a problem hiding this comment.
Could we reuse the data from FileSearchBackend::getPropertyDefinitionsForScope here somehow? or create a shared source of truth somewhere else
icewind1991
reviewed
Sep 21, 2026
Comment on lines
+305
to
+309
| $chunks = array_map( | ||
| static fn (array $chunk): ISearchOperator | ||
| => new SearchComparison(ISearchComparison::COMPARE_IN, 'fileid', array_values($chunk)), | ||
| array_chunk($ids, self::ID_CHUNK), | ||
| ); |
Member
There was a problem hiding this comment.
there is no need to chunk here, the backend will take care of it
icewind1991
reviewed
Sep 21, 2026
|
|
||
| return [ | ||
| 'shared' => $entries !== [], | ||
| 'externally' => array_filter($entries, static fn (array $e): bool => $e['external']) !== [], |
Member
There was a problem hiding this comment.
array_any or track a single boolean trough the above loops.
Member
|
(only looked at part of the code so far, non-existence of comments on code should not be takes as a non-existence of (possible) issues) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
See
occ search:providersandocc search:queryfor using thisTODO
Checklist
3. to review, feature component)stable32)AI (if applicable)