fix(dav): pair changed iTip instances by UID/RECURRENCE-ID instead of… - #64635
Draft
SebastianKrupinski wants to merge 1 commit into
Draft
SebastianKrupinski wants to merge 1 commit into
SebastianKrupinski wants to merge 1 commit into
Conversation
… array position Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
SebastianKrupinski
requested review from
DerDreschner,
kesselb and
odzhychko
September 21, 2026 15:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… array position
Summary
Folded EventComparisonService into IMipService::findModifiedInstances(). Now matches old/new instances by UID + RECURRENCE-ID instead of relying on array position, this fixes a latent bug in the old code where matching never checked UID at all.
schedule() no longer silently drops instances, it inspects every changed instance, deterministically prefers the master when present (instead of "whatever array_pop left"), and logs via debug() when other changed instances exist but aren't reflected in the email.
Checklist
3. to review, feature component)stable32)AI (if applicable)